linux-kernel - RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN1PR0301MB158305ED5DD0A4E4265A851DE0D00@SN1PR0301MB1583.namprd03.prod.outlook.com>
Date:	Wed, 6 May 2015 14:25:30 +0000
From:	Ramneek Mehresh <ramneek.mehresh@...escale.com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Kernel development list <linux-kernel@...r.kernel.org>,
	Felipe Balbi <balbi@...com>,
	USB list <linux-usb@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host
 driver



> -----Original Message-----
> From: Alan Stern [mailto:stern@...land.harvard.edu]
> Sent: Wednesday, May 06, 2015 7:49 PM
> To: Mehresh Ramneek-B31383
> Cc: Kernel development list; Felipe Balbi; USB list;
> gregkh@...uxfoundation.org
> Subject: RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb
> host driver
> 
> On Wed, 6 May 2015, Ramneek Mehresh wrote:
> 
> > > Also, I'm not going to let you add new fields into the
> > > ehci_driver_overrides structure.  If you really need to override
> > > other routines, copy the approach used by ehci-tegra.c.
> > >
> > Understood...but I would appreciate if you could please explain the
> > harm in doing so
> 
> The fields in the override structure are meant for convenience.  The
> extra_priv_size field is the most important one; the other two fields (reset
> and port_power) are present only because so many drivers need them.
> 
> There's no reason to add an extra field for something that will be used in only
> one driver.  You can do the override by hand, instead of wasting space in a
> whole bunch of other drivers.
> 
Ok...i thought "overrides" structure is to enforce a field by a driver on generic structure...
But now it appears that it's only for most popular fields only...i'll make changes in my driver only

> Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/