linux-kernel - RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1505061045150.1094-100000@iolanthe.rowland.org>
Date:	Wed, 6 May 2015 10:47:29 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ramneek Mehresh <ramneek.mehresh@...escale.com>
cc:	Kernel development list <linux-kernel@...r.kernel.org>,
	Felipe Balbi <balbi@...com>,
	USB list <linux-usb@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host
 driver

On Wed, 6 May 2015, Ramneek Mehresh wrote:

> > The fields in the override structure are meant for convenience.  The
> > extra_priv_size field is the most important one; the other two fields (reset
> > and port_power) are present only because so many drivers need them.
> > 
> > There's no reason to add an extra field for something that will be used in only
> > one driver.  You can do the override by hand, instead of wasting space in a
> > whole bunch of other drivers.
> > 
> Ok...i thought "overrides" structure is to enforce a field by a driver on generic structure...

Consider what would happen if that were true.  Your driver would want
to override three extra fields, so you would add them to the structure.  
Some other driver would want to override two others, so it would add 
them to the structure.  Then some other driver would need to override 
more fields...  Eventually the overrides structure would contain 
everything that is already present in struct ehci_hcd!

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/