linux-kernel - Re: [PATCH v4 2/3] memory-failure: change type of action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150507000835.GA2954@hori1.linux.bs1.fc.nec.co.jp>
Date:	Thu, 7 May 2015 00:08:35 +0000
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Xie XiuQi <xiexiuqi@...wei.com>
CC:	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
	"koct9i@...il.com" <koct9i@...il.com>,
	"hpa@...ux.intel.com" <hpa@...ux.intel.com>,
	"hannes@...xchg.org" <hannes@...xchg.org>,
	"iamjoonsoo.kim@....com" <iamjoonsoo.kim@....com>,
	"luto@...capital.net" <luto@...capital.net>,
	"nasa4836@...il.com" <nasa4836@...il.com>,
	"gong.chen@...ux.intel.com" <gong.chen@...ux.intel.com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"bp@...e.de" <bp@...e.de>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"jingle.chen@...wei.com" <jingle.chen@...wei.com>
Subject: Re: [PATCH v4 2/3] memory-failure: change type of action_result's
 param 3 to enum

On Mon, Apr 20, 2015 at 04:44:39PM +0800, Xie XiuQi wrote:
> Change type of action_result's param 3 to enum for type consistency,
> and rename mf_outcome to mf_result for clearly.
> 
> Signed-off-by: Xie XiuQi <xiexiuqi@...wei.com>

Acked-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>

> ---
>  include/linux/mm.h  | 2 +-
>  mm/memory-failure.c | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 8413615..93c4a00 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2156,7 +2156,7 @@ extern int soft_offline_page(struct page *page, int flags);
>  /*
>   * Error handlers for various types of pages.
>   */
> -enum mf_outcome {
> +enum mf_result {
>  	MF_IGNORED,	/* Error: cannot be handled */
>  	MF_FAILED,	/* Error: handling failed */
>  	MF_DELAYED,	/* Will be handled later */
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 6f5748d..f074f8e 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -847,7 +847,8 @@ static struct page_state {
>   * "Dirty/Clean" indication is not 100% accurate due to the possibility of
>   * setting PG_dirty outside page lock. See also comment above set_page_dirty().
>   */
> -static void action_result(unsigned long pfn, enum mf_action_page_type type, int result)
> +static void action_result(unsigned long pfn, enum mf_action_page_type type,
> +			  enum mf_result result)
>  {
>  	pr_err("MCE %#lx: recovery action for %s: %s\n",
>  		pfn, action_page_types[type], action_name[result]);
> -- 
> 1.8.3.1
> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/