linux-kernel - Re: [PATCH v4] video: mxsfb: Make sure axi clock is enabled when accessing registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <554B45CA.2010103@ti.com>
Date:	Thu, 7 May 2015 14:00:26 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Liu Ying <Ying.Liu@...escale.com>, <linux-fbdev@...r.kernel.org>
CC:	Peter Chen <peter.chen@...escale.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH v4] video: mxsfb: Make sure axi clock is enabled when
 accessing registers

On 03/04/15 07:51, Liu Ying wrote:
> The LCDIF engines embedded in i.MX6sl and i.MX6sx SoCs need the axi clock
> as the engine's system clock.  The clock should be enabled when accessing
> LCDIF registers, otherwise the kernel would hang up.  We should also keep
> the clock enabled when the engine is being active to scan out frames from
> memory.  This patch makes sure the axi clock is enabled when accessing
> registers so that the kernel hang up issue can be fixed.
> 
> Reported-by: Peter Chen <peter.chen@...escale.com>
> Tested-by: Peter Chen <peter.chen@...escale.com>
> Cc: <stable@...r.kernel.org> # 3.19+
> Signed-off-by: Liu Ying <Ying.Liu@...escale.com>
> ---
> v3->v4:
> * To address Tomi's comment, enable/disable the axi clock in
>   mxsfb_pan_display() directly instead of checking the host->enabled flag.
> 
> v2->v3:
> * To address Tomi's comment, improve the commit message only.
> 
> v1->v2:
> * Add 'Tested-by: Peter Chen <peter.chen@...escale.com>' tag.
> * Add 'Cc: <stable@...r.kernel.org> # 3.19+' tag.
> 
>  drivers/video/fbdev/mxsfb.c | 68 +++++++++++++++++++++++++++++++++++----------
>  1 file changed, 54 insertions(+), 14 deletions(-)

Thanks, queued for 4.2.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)