[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1431017979-28349-1-git-send-email-joe.konno@linux.intel.com>
Date: Thu, 7 May 2015 09:59:39 -0700
From: Joe Konno <joe.konno@...ux.intel.com>
To: linux-pm@...r.kernel.org
Cc: rjw@...ysocki.net, viresh.kumar@...aro.org,
linux-kernel@...r.kernel.org, kristen@...ux.intel.com
Subject: [PATCH] intel_pstate: set BYT MSR with wrmsrl_on_cpu()
From: Joe Konno <joe.konno@...el.com>
In instances where the default cpufreq governor is Performance, reading
from MSR 0x199 on an applicable multi-core Atom system saw boot-to-boot
variability in the P-State value set to each logical core. Sometimes
only one logical core would be set properly, other times two or three.
There was an assumption in the code that only a thread on the intended
logical core would be calling the wrmsrl() function. That was disproven
during debug, as cpufreq, at init, was not always calling from the same
as the logical core it targeted. Thus, use wrmsrl_on_cpu() instead, as
done in the core_set_pstate() function.
For: LCK-1822
Fixes: 007bea098b86 ("intel_pstate: Add setting voltage value for
baytrail P states.")
Signed-off-by: Joe Konno <joe.konno@...el.com>
---
drivers/cpufreq/intel_pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 6414661ac1c4..c45d274a75c8 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -535,7 +535,7 @@ static void byt_set_pstate(struct cpudata *cpudata, int pstate)
val |= vid;
- wrmsrl(MSR_IA32_PERF_CTL, val);
+ wrmsrl_on_cpu(cpudata->cpu, MSR_IA32_PERF_CTL, val);
}
#define BYT_BCLK_FREQS 5
--
2.4.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists