linux-kernel - Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150507195658.GT22845@sirena.org.uk>
Date:	Thu, 7 May 2015 20:56:58 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Michael Welling <mwelling@...e.org>
Cc:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

On Thu, May 07, 2015 at 02:38:52PM -0500, Michael Welling wrote:
> On Thu, May 07, 2015 at 08:27:58PM +0100, Mark Brown wrote:
> > On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote:
> > > On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote:

> > > I noticed a few oddities in the code when converting.

> > > For instance:
> > > http://lxr.free-electrons.com/source/drivers/spi/spi-omap2-mcspi.c#L1225

> > > What is the point of trying to print tx or rx given the if statement
> > > insures that rx_buff and tx_buff are NULL?

> > I expect it's just a buggy test.

> Not sure I understand what you mean.

I expect that the code is just being silly.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)