linux-kernel - Re: [PATCH 03/12] clocksource: sti: Provide 'use timer as sched clock' capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1431085625.13593.39.camel@x220>
Date:	Fri, 08 May 2015 13:47:05 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel@...inux.com, devicetree@...r.kernel.org,
	daniel.lezcano@...aro.org, tglx@...utronix.de, wim@...ana.be,
	a.zummo@...ertech.it, linux-watchdog@...r.kernel.org,
	rtc-linux@...glegroups.com, linux@...ck-us.net
Subject: Re: [PATCH 03/12] clocksource: sti: Provide 'use timer as sched
 clock' capability

On Fri, 2015-05-08 at 11:29 +0100, Lee Jones wrote:
> Ah, you mean from menuconfig.  I almost forgot what that was. ;)
> 
> I can add a menu option, no problem.

It's not just menuconfig:
    $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config 
    CONFIG_ARCH_STI=y
    CONFIG_CLKSRC_ST_LPC=y
    CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK=y
    $ vim .config 
    $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config 
    CONFIG_ARCH_STI=y
    # CONFIG_CLKSRC_ST_LPC is not set
    # CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK is not set
    $ make ARCH=arm silentoldconfig
    scripts/kconfig/conf  --silentoldconfig Kconfig
    #
    # configuration written to .config
    #
    $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config 
    CONFIG_ARCH_STI=y
    CONFIG_CLKSRC_ST_LPC=y
    CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK=y

So I think that, if you want to be able to set
CLKSRC_ST_LPC_TIMER_SCHED_CLOCK to 'n' even though CLKSRC_ST_LPC is 'y',
you need to add a prompt. Or have you found a way around this?

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/