linux-kernel - Re: [PATCH v2] serial: imx: Revert "initialized DMA w/o HW flow enabled"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <554CA317.8050303@linutronix.de>
Date:	Fri, 08 May 2015 13:50:47 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Fabio Estevam <festevam@...il.com>,
	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	jiwang <jiada_wang@...tor.com>, Jiri Slaby <jslaby@...e.cz>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	anton_bondarenko@...tor.com, Dirk Behme <dirk.behme@...bosch.com>,
	Nicolae Rosia <nicolae.rosia@...il.com>,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH v2] serial: imx: Revert "initialized DMA w/o HW flow enabled"

On 05/08/2015 01:30 PM, Fabio Estevam wrote:
> On Fri, May 8, 2015 at 4:13 AM, Sebastian Andrzej Siewior
> <sebastian@...akpoint.cc> wrote:
> 
>> +
>> +                       /*
>> +                        * Can we enable the DMA support? Be aware that
>> +                        * at least IMX6 needs to load external SDMA firmware in
>> +                        * order work properly. The in-ROM firmware is not
>> +                        * wokring properly.
>> +                        */
> 
> On my tests:
> 
> Prior to this patch: with the internal ROM SDMA firmware I got UART
> issues when communicating through a Bluetooth module. With external
> SDMA firmware (version 3.1) it worked fine.
> 
> With your patch applied: Bluetooth worked fine even with no external
> SDMA firmware, which does not match the comments you added.

Why doesn't it match the comment? The patch disables DMA so the SDMA
firmware does not matter.

> Can't you just remove these comments?
> 
> Thanks

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/