linux-kernel - Re: [PATCH v2] staging: rtl8192e: Change cpu_to_le16 to le16_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150509221312.GF14154@mwanda>
Date:	Sun, 10 May 2015 01:13:12 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Arno Tiemersma <arno.tiemersma@...il.com>
Cc:	gregkh@...uxfoundation.org, mateusz.kulikowski@...il.com,
	behanw@...verseincode.com, mdcasey@...bloom.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192e: Change cpu_to_le16 to le16_to_cpu

On Sat, May 09, 2015 at 10:27:16PM +0200, Arno Tiemersma wrote:
> Since the function auth_parse returns a u16, and
> struct rtllib_authentication.status is defined as an __le16, it seems
> that
> 
> 	return cpu_to_le16(a->status);
> 
> should be
> 
> 	return le16_to_cpu(a->status);
> 
> This change silences the following sparse warnings:
> drivers/staging/rtl8192e/rtllib_softmac.c:1817:16:
>  warning: cast from restricted __le16
> drivers/staging/rtl8192e/rtllib_softmac.c:1817:16:
>  warning: incorrect type in return expression (different base types)
> drivers/staging/rtl8192e/rtllib_softmac.c:1817:16:
>     expected unsigned short
> drivers/staging/rtl8192e/rtllib_softmac.c:1817:16:
>     got restricted __le16 [usertype] <noident>
> 
> Signed-off-by: Arno Tiemersma <arno.tiemersma@...il.com>

Your patch seems reasonable.  The caller only cares about zero non-zero.

It feels like there are a bunch of endian bugs which Sparse misses in
this file.  For example, ->frame_ctl is endian but it's never converted
and it's compared against cpu endian in the switch statements.  (I
haven't double checked.  Do your own homework before sending patches).

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/