[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <554E8735.302@gmail.com>
Date: Sun, 10 May 2015 00:16:21 +0200
From: Philippe Reynes <tremyfr@...il.com>
To: Fabio Estevam <festevam@...il.com>
CC: Russell King - ARM Linux <linux@....linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Duan Fugang-B38611 <B38611@...escale.com>,
Frank Li <Frank.Li@...escale.com>,
Lothar Waßmann <LW@...o-electronics.de>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: fec: add support of ethtool get_regs
Hi Fabio,
On 09/05/15 23:59, Fabio Estevam wrote:
> Philippe,
>
> On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
> <linux@....linux.org.uk> wrote:
>
>> Using memcpy_fromio() to copy device registers is not a good idea -
>> it can use a variable access size which can cause bus faults.
>
> An example on how memcpy_fromio() can be avoided in get_regs:
> drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c
Thanks for pointing me this example. I've already send a patch,
and I've used drivers/net/ethernet/freescale/gianfar_ethtool.c
as example. I hope it's a good example too.
> Regards,
>
> Fabio Estevam
Regards,
Philippe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists