[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.00.1505112345430.8186@pobox.suse.cz>
Date: Mon, 11 May 2015 23:46:04 +0200 (CEST)
From: Jiri Kosina <jkosina@...e.cz>
To: Nicholas Mc Guire <hofrat@...dl.org>
cc: Josh Poimboeuf <jpoimboe@...hat.com>,
Seth Jennings <sjenning@...hat.com>,
Vojtech Pavlik <vojtech@...e.cz>,
live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] livepatch: match return value to function signature
On Mon, 11 May 2015, Nicholas Mc Guire wrote:
> klp_initialized() should return bool but is actually returning
> struct kobject * - convert it to a boolean explicitly.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
>
> static code checking was not happy with
> ./kernel/livepatch/core.c:131 WARNING: return of wrong type
> bool != struct kobject *
>
> This adds !! to explicitly convert to boolean type.
>
> Patch was compile tested with x86_64_defconfig
>
> patch is against 4.1-rc2 (localversion-next is -next-20150508)
Applied to for-4.2/upstream. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists