lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150511164223.GA2746@treble.redhat.com>
Date:	Mon, 11 May 2015 11:42:23 -0500
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Seth Jennings <sjenning@...hat.com>, Jiri Kosina <jkosina@...e.cz>,
	Vojtech Pavlik <vojtech@...e.cz>,
	live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] livepatch: match return value to function signature

On Mon, May 11, 2015 at 07:52:29AM +0200, Nicholas Mc Guire wrote:
> klp_initialized() should return bool but is actually returning 
> struct kobject * - convert it to a boolean explicitly.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
> 
> static code checking was not happy with
>  ./kernel/livepatch/core.c:131 WARNING: return of wrong type
>                                bool != struct kobject *
> 
> This adds !! to explicitly convert to boolean type.
> 
> Patch was compile tested with x86_64_defconfig
> 
> patch is against 4.1-rc2 (localversion-next is -next-20150508)
> 
>  kernel/livepatch/core.c     |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index 0e7c23c..c0ae3d8 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -128,7 +128,7 @@ static bool klp_is_patch_registered(struct klp_patch *patch)
>  
>  static bool klp_initialized(void)
>  {
> -	return klp_root_kobj;
> +	return !!klp_root_kobj;
>  }
>  
>  struct klp_find_arg {
> -- 
> 1.7.10.4
> 

Thanks!

Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ