linux-kernel - Re: [PATCH] staging: panel: fix stackdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 May 2015 13:44:56 +0200
From:	Willy Tarreau <w@....eu>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: panel: fix stackdump

On Mon, May 11, 2015 at 04:42:19PM +0530, Sudip Mukherjee wrote:
> if we load the module, unload and then again try to load the module, we
> will get a stackdump. In the module_exit function we are unregistering
> the device and releasing the parport. So when we reach the detach
> function parport is already null and the unregister_reboot_notifier()
> is never called. When we again try to load the module it again tries
> register_reboot_notifier() and gives us a stackdump as its earlier
> registration is still not removed.
> Fix this by moving all the unregistering and releasing in the detach
> function, which should be the ideal case as the detach will be called if
> we try to unregister the driver or if the parport is removed.
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
> 
> This was caused by one of my patch :(
> Faced this problem while working on the device-model code of
> parallelport.

Introducing regressions (and fixing them) is part of the job :-)

However please mention in the commit message the commit of your other patch
which introduced the regression, and if you noticed it was backported to
stable, please mention it as well by a Cc: stable and the idea of the commit.
That will help everyone involved in the chain.

Thanks,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/