linux-kernel - Re: [PATCH 1/2] clone: Support passing tls argument via C rather than pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150511140043.GB5354@gmail.com>
Date:	Mon, 11 May 2015 16:00:43 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Andy Lutomirski <luto@...capital.net>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH 1/2] clone: Support passing tls argument via C rather
 than pt_regs magic


* Josh Triplett <josh@...htriplett.org> wrote:

> On Mon, May 11, 2015 at 12:13:13PM +0200, Ingo Molnar wrote:
> > 
> > * josh@...htriplett.org <josh@...htriplett.org> wrote:
> > 
> > > On Tue, May 05, 2015 at 08:53:03PM +0200, Thomas Gleixner wrote:
> > > > On Tue, 21 Apr 2015, Josh Triplett wrote:
> > > > > 
> > > > > Signed-off-by: Josh Triplett <josh@...htriplett.org>
> > > > > Signed-off-by: Thiago Macieira <thiago.macieira@...el.com>
> > > > 
> > > > Can you please clarify that SOB chain? It does not make any sense.
> > > 
> > > Co-authored patch.  We both worked on it together, and sadly git 
> > > doesn't support a commit with multiple authors, so this is the next 
> > > best thing.
> > 
> > No, this is not a valid SOB chain.
> > 
> > For 'co authored' patches you can add credits either to the file, 
> > as two copyright lines, or via the changelog, no need to mess up 
> > the SOB chain for that.
> 
> Fine, I'll write it another way.
> 
> Do you see any other issues with the patch other than the signoffs?

Looks good to me, but I have not looked very deeply ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/