linux-kernel - Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <61BE0C45-D46F-4A2E-9B78-E38069398810@martin.sperl.org>
Date:	Mon, 11 May 2015 07:11:43 +0200
From:	Martin Sperl <kernel@...tin.sperl.org>
To:	Jonathan Bell <jonathan@...pberrypi.org>
Cc:	Noralf Trønnes <noralf@...nnes.org>,
	Stephen Warren <swarren@...dotorg.org>,
	dmaengine@...r.kernel.org, vinod.koul@...el.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
	dan.j.williams@...el.com, linux-spi <linux-spi@...r.kernel.org>
Subject: Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

> On 08.05.2015, at 13:20, Jonathan Bell <jonathan@...pberrypi.org> wrote:
>> 
> I agree that the interrupt generated would be spurious - in the case where it is not required.
> 
> However if you do && (flags & DMA_PREP_INTERRUPT) then all users of this driver need to explicitly set interrupt flags when doing a scatter-gather transfer. As I understand it, currently the only upstream client of this driver is the I2S driver which only uses cyclic anyway.
> 
> Not requiring an interrupt on completion is a bit of an edge case - the default among other dmaengine drivers appears to be to enable interrupts unconditionally.

I have now submitted a patch for spi-bcm2835 to make use of dma,
so there is one candidate for this kind of behavior.
So please go forward with the merge.

Also note that with the spi-HW dma support of the bcm2835
it is necessary to do a RX transfer even if the data is not
used (similar for TX).

Right now we have to allocate a dummy buffer to run these kind
of “one-way” transfers where we need 2 DMA channels.

The bcm2835 dma hw supports such dummy-transfer modes via 
BCM2835_DMA_S_IGNORE and BCM2835_DMA_D_IGNORE.

So maybe we can add a “flag” to the dmaengine_prep_slave_sg
that will allow such kind of behavior to get implemented?

That is not a necessity, but would be a welcome improvement.

Tested-by: Martin Sperl <kernel@...tin.sperl.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/