linux-kernel - Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5552231A.9010503@tronnes.org>
Date:	Tue, 12 May 2015 17:58:18 +0200
From:	Noralf Trønnes <noralf@...nnes.org>
To:	dmaengine@...r.kernel.org, vinod.koul@...el.com,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>
CC:	linux-kernel@...r.kernel.org, jonathan@...pberrypi.org,
	linux-rpi-kernel@...ts.infradead.org, dan.j.williams@...el.com
Subject: Re: [PATCH v2] dmaengine: bcm2835: Add slave dma support

Hi,

Den 18.04.2015 13:06, skrev Noralf Trønnes:
> Add slave transfer capability to BCM2835 dmaengine driver.
> This patch is pulled from the bcm2708-dmaengine driver in the
> Raspberry Pi repo. The work was done by Gellert Weisz.
>
> Tested using the bcm2835-mmc driver from the same repo.
>
> Signed-off-by: Noralf Trønnes <noralf@...nnes.org>
> ---
>
> Gellert Weisz has ended his internship with Raspberry Pi Trading and
> was not available to sign off this patch.
>
> The patch is made against mainline 4.0-rc7.
>
> Changes from v1:
> 	Martin Sperl, Dom Cobley:
> 	MAX_LITE_TRANSFER has to be 32-bit aligned
>
> 	Stefan Wahren:
> 	Variable es is not used
> 	Change splitct to split_cnt
> 	Add dev_err for unsupported buswidth
> 	Rearrange d->frames formula for readability
> 	Move j variable definition to loop
>
> Changes from original code:
> 	Remove slave_id use.
> 	SDHCI_BCM_DMA_WAITS changed to BCM2835_DMA_WAIT_CYCLES.
> 	Use SZ_* macros instead of decimal values.
> 	Change MAX_LITE_TRANSFER from 32k to 64K - 1.
> 	Fix several whitespace issues.
>
> 	Lee Jones' comments in previous email to Piotr Król:
> 	Remove __func__ from dev_err message.
> 	Cleanup comments.

Is there something missing for this patch to get accepted?
spi-bcm2835 has now DMA support that depends on this patch.


Noralf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/