linux-kernel - Re: [PATCH v3 15/22] time/posix-timers:Convert to the 64bit methods for k

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9198494.K1zFNegC4D@wuerfel>
Date:	Tue, 12 May 2015 10:51:38 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Baolin Wang <baolin.wang@...aro.org>
Cc:	tglx@...utronix.de, john.stultz@...aro.org, heenasirwani@...il.com,
	pang.xunlei@...aro.org, peterz@...radead.org,
	rafael.j.wysocki@...el.com, linux-kernel@...r.kernel.org,
	y2038@...ts.linaro.org
Subject: Re: [PATCH v3 15/22] time/posix-timers:Convert to the 64bit methods for k_clock callback functions

On Monday 11 May 2015 19:20:39 Baolin Wang wrote:
> diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h
> index 89beb62..c3345d5 100644
> --- a/include/linux/timekeeping.h
> +++ b/include/linux/timekeeping.h
> @@ -250,9 +250,9 @@ static inline void get_monotonic_boottime64(struct timespec64 *ts)
>         *ts = ktime_to_timespec64(ktime_get_boottime());
>  }
>  
> -static inline void timekeeping_clocktai(struct timespec *ts)
> +static inline void timekeeping_clocktai(struct timespec64 *ts)
>  {
> -       *ts = ktime_to_timespec(ktime_get_clocktai());
> +       *ts = ktime_to_timespec64(ktime_get_clocktai());
>  }
>  
>  /*
> 

I believe Thomas has already mentioned before that the change to the
timekeeping_clocktai() function is not obvious here. I'd suggest you
split out the changes here along with the posix_get_tai() that
calls it into its own patch with a good description, and leave all
the simple changes to kernel/time/posix-timers.c in a second patch.

I don't think it's necessary to split up the other changes from
this patch any further. If Thomas or someone else disagrees with this
and wants it more fine-grained, it would be good to say that now.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/