linux-kernel - Re: [PATCH 2/2 v2] lib/vsprintf.c: Further simplify uuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	12 May 2015 09:57:36 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	linux@...izon.com, linux@...musvillemoes.dk
Cc:	joe@...ches.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2 v2] lib/vsprintf.c: Further simplify uuid_string()

> Acked-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> 
> You may want/need to include Andrew Morton in the cc-list to get these
> picked up.

Thank you; I sent it to you because I'm not sure who's really in charge
of this.

>> +	/* Insert the fixed punctuation */
>> +	uuid[23] = uuid[18] = uuid[13] = uuid[8] = '-';
>> +	uuid[36] = 0;

> I think '\0' is more common.

It's that way beause of it was replacing

>> -	*p = 0;

But yes, I prefer the char constant, too.  And it would be consistent with
the rest of the file.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/