linux-kernel - Re: [PATCH 2/2 v2] lib/vsprintf.c: Further simplify uuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 09:59:39 -0700
From:	Joe Perches <joe@...ches.com>
To:	George Spelvin <linux@...izon.com>
Cc:	linux@...musvillemoes.dk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2 v2] lib/vsprintf.c: Further simplify uuid_string()

On Tue, 2015-05-12 at 09:57 -0400, George Spelvin wrote:
> > Acked-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> > 
> > You may want/need to include Andrew Morton in the cc-list to get these
> > picked up.
> 
> Thank you; I sent it to you because I'm not sure who's really in charge
> of this.

Andrew generally gets these sorts of changes applied.

> >> +	/* Insert the fixed punctuation */
> >> +	uuid[23] = uuid[18] = uuid[13] = uuid[8] = '-';
> >> +	uuid[36] = 0;
> 
> > I think '\0' is more common.
> 
> It's that way beause of it was replacing
> 
> >> -	*p = 0;
> 
> But yes, I prefer the char constant, too.  And it would be consistent with
> the rest of the file.

I think I did that "*p = 0;" because that's what
I normally use, but consistency is better.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/