linux-kernel - Re: [PATCH 2/3] ASoC: fsl_sai: Add tdm slots operation for SAI master mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150512184237.GP3066@sirena.org.uk>
Date:	Tue, 12 May 2015 19:42:37 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Zidan Wang <zidan.wang@...escale.com>
Cc:	nicoleotsuka@...il.com, timur@...i.org, Xiubo.Lee@...il.com,
	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de,
	alsa-devel@...a-project.org, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ASoC: fsl_sai: Add tdm slots operation for SAI
 master mode

On Mon, May 11, 2015 at 06:24:42PM +0800, Zidan Wang wrote:

>  	if (!sai->is_slave_mode) {
> +		slot_width = sai->slot_width;
>  		ret = fsl_sai_set_bclk(cpu_dai, tx,
> -			2 * word_width * params_rate(params));
> +				sai->slots * slot_width * params_rate(params));
>  		if (ret)

This seems to make TDM configuration mandatory which seems like a step
back - if it's been set up then of course we need to use it but if it's
not been configured we should be able to just infer something from
hw_params as we have been doing.  Checking to see if the relevant values
have been set and falling back to using hw_params seems better.

Otherwise this looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)