lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150513122200.GU3394@x1>
Date:	Wed, 13 May 2015 13:22:00 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	broonie@...nel.org, lgirdwood@...il.com, sameo@...ux.intel.com,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v3 10/10] mfd: wm5110: Add delay before releasing
 reset line

On Mon, 11 May 2015, Charles Keepax wrote:

> On the wm5110 it is important the reset line is held for slightly longer
> to ensure the device starts up well. This patch adds a 5mS delay for
> this.
> 
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> Acked-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/mfd/arizona-core.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index f1ff68a..93e4d94 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -259,6 +259,16 @@ static inline void arizona_enable_reset(struct arizona *arizona)
>  static void arizona_disable_reset(struct arizona *arizona)
>  {
>  	if (arizona->pdata.reset) {
> +		switch (arizona->type) {
> +		case WM5110:
> +		case WM8280:
> +			/* Meet requirements for minimum reset duration */
> +			msleep(5);
> +			break;
> +		default:
> +			break;
> +		}
> +
>  		gpio_set_value_cansleep(arizona->pdata.reset, 1);
>  		msleep(1);
>  	}

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ