linux-kernel - Re: [PATCH] block:Remove including of the header file, linux/mm.h for the file,nvme-core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150513164945.GX4003@linux.intel.com>
Date:	Wed, 13 May 2015 12:49:45 -0400
From:	Matthew Wilcox <willy@...ux.intel.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block:Remove including of the header file, linux/mm.h
 for the file,nvme-core.c

On Wed, May 13, 2015 at 12:21:18PM -0400, Nicholas Krause wrote:
> This removes the include statement for including the header file,
> linux/mm.h in the file, nvme-core.c due this driver file never
> calling any functions from the header file, linux/mm.h  and
> only adding bloat to this driver by including this unnessary
> header file.

Nick, I'm not going to apply this patch, simply because the effort of
verifying that you haven't made a mistake is greater than the gain we
might get from applying it.  Your earlier patch shows that you haven't
actually learned anything since I first heard about your patches.
Please, continue learning before submitting more patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/