linux-kernel - Re: [PATCH] block:Remove including of the header file, linux/mm.h for the file,nvme-core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 May 2015 17:12:10 +0000 (UTC)
From:	Keith Busch <keith.busch@...el.com>
To:	Matthew Wilcox <willy@...ux.intel.com>
cc:	Nicholas Krause <xerofoify@...il.com>,
	linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org
Subject: Re: [PATCH] block:Remove including of the header file, linux/mm.h
 for the file,nvme-core.c

On Wed, 13 May 2015, Matthew Wilcox wrote:
> On Wed, May 13, 2015 at 12:21:18PM -0400, Nicholas Krause wrote:
>> This removes the include statement for including the header file,
>> linux/mm.h in the file, nvme-core.c due this driver file never
>> calling any functions from the header file, linux/mm.h  and
>> only adding bloat to this driver by including this unnessary
>> header file.
>
> Nick, I'm not going to apply this patch, simply because the effort of
> verifying that you haven't made a mistake is greater than the gain we
> might get from applying it.

The driver does use functions defined in linux/mm.h: get_user_pages_fast
is one of them. It compiles without including the header because another
we include includes mm.h, but we don't want to depend on that!

Don't worry, I didn't waste time checking; I just happened to know that
one off the top.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/