[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5553BAB4.3040209@maciej.szmigiero.name>
Date: Wed, 13 May 2015 22:57:24 +0200
From: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To: Mark Brown <broonie@...nel.org>
CC: alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
Lars-Peter Clausen <lars@...afoo.de>,
Brian Austin <brian.austin@...rus.com>,
Bard Liao <bardliao@...ltek.com>,
Oder Chiou <oder_chiou@...ltek.com>,
Wolfram Sang <wsa@...-dreams.de>, linux-kernel@...r.kernel.org,
Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH] ASoC: codecs-ac97: make selectable in config
Thanks for looking into the patch.
W dniu 12.05.2015 19:58, Mark Brown pisze:
> On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote:
>
>> @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS
>> select SND_SOC_88PM860X if MFD_88PM860X
>> select SND_SOC_L3
>> select SND_SOC_AB8500_CODEC if ABX500_CORE
>> - select SND_SOC_AC97_CODEC if SND_SOC_AC97_BUS
>> + select SND_SOC_AC97_CODEC
>> select SND_SOC_AD1836 if SPI_MASTER
>> select SND_SOC_AD193X_SPI if SPI_MASTER
>> select SND_SOC_AD193X_I2C if I2C
>
> No, you're missing the point of what _ALL_CODECS does - it builds
> everything possible. This will break the build for systems without
> AC'97 support.
How?
In the second hunk of the patch I've made SND_SOC_AC97_CODEC select
SND_SOC_AC97_BUS.
ASoC AC'97 CODEC uses only AC'97 symbols defined in
pci/ac97/ac97_codec.c, pci/ac97/ac97_pcm.c and sound/soc/soc-ac97.c.
pci/ac97/ac97_codec.c, pci/ac97/ac97_pcm.c will be built via
SND_SOC_ALL_CODECS -> SND_SOC_AC97_CODEC -> SND_AC97_CODEC dependency.
sound/soc/soc-ac97.c will be build via SND_SOC_ALL_CODECS ->
SND_SOC_AC97_CODEC -> SND_SOC_AC97_BUS dependency.
Best regards,
Maciej Szmigiero
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists