linux-kernel - Re: [PATCH] ASoC: codecs-ac97: make selectable in config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150514175351.GQ2761@sirena.org.uk>
Date:	Thu, 14 May 2015 18:53:52 +0100
From:	Mark Brown <broonie@...nel.org>
To:	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc:	alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Brian Austin <brian.austin@...rus.com>,
	Bard Liao <bardliao@...ltek.com>,
	Oder Chiou <oder_chiou@...ltek.com>,
	Wolfram Sang <wsa@...-dreams.de>, linux-kernel@...r.kernel.org,
	Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH] ASoC: codecs-ac97: make selectable in config

On Wed, May 13, 2015 at 10:57:24PM +0200, Maciej S. Szmigiero wrote:
> W dniu 12.05.2015 19:58, Mark Brown pisze:
> > On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote:

> >> @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS
> >>  	select SND_SOC_88PM860X if MFD_88PM860X
> >>  	select SND_SOC_L3
> >>  	select SND_SOC_AB8500_CODEC if ABX500_CORE
> >> -	select SND_SOC_AC97_CODEC if SND_SOC_AC97_BUS
> >> +	select SND_SOC_AC97_CODEC
> >>  	select SND_SOC_AD1836 if SPI_MASTER
> >>  	select SND_SOC_AD193X_SPI if SPI_MASTER
> >>  	select SND_SOC_AD193X_I2C if I2C

> > No, you're missing the point of what _ALL_CODECS does - it builds
> > everything possible.  This will break the build for systems without
> > AC'97 support.

> How?
> In the second hunk of the patch I've made SND_SOC_AC97_CODEC select
> SND_SOC_AC97_BUS.

select doesn't respect dependencies, it'll just force on the selected
symbol.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)