linux-kernel - Re: [net-next PATCH] net: Reserve skb headroom and set skb->dev even if using __alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7h8ucs6tzc.fsf@deeprootsystems.com>
Date:	Wed, 13 May 2015 14:35:51 -0700
From:	Kevin Hilman <khilman@...nel.org>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>
Cc:	linux-kernel@...r.kernel.org, balbi@...com, davem@...emloft.net,
	tony@...mide.com, netdev@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [net-next PATCH] net: Reserve skb headroom and set skb->dev even if using __alloc_skb

Alexander Duyck <alexander.h.duyck@...hat.com> writes:

> When I had inlined __alloc_rx_skb into __netdev_alloc_skb and
> __napi_alloc_skb I had overlooked the fact that there was a return in the
> __alloc_rx_skb.  As a result we weren't reserving headroom or setting the
> skb->dev in certain cases.  This change corrects that by adding a couple of
> jump labels to jump to depending on __alloc_skb either succeeding or failing.
>
> Fixes: 9451980a6646 ("net: Use cached copy of pfmemalloc to avoid accessing page")
> Reported-by: Felipe Balbi <balbi@...com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>

Tested this on top of next-20150513 on an ARM/OMAP
(am335x-boneblack.dts) an it fixes the boot problem for me.

Tested-by: Kevin Hilman <khilman@...aro.org>

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/