linux-kernel - Re: [PATCH 2/2] selftests/breakpoints: only set TEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 May 2015 15:41:47 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	tyler.baker@...aro.org
CC:	Andy Lutomirski <luto@...capital.net>,
	Kevin Hilman <khilman@...nel.org>,
	John Stultz <john.stultz@...aro.org>,
	Darren Hart <dvhart@...radead.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	David Herrmann <dh.herrmann@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 2/2] selftests/breakpoints: only set TEST_PROGS when built

On 05/12/2015 03:59 PM, tyler.baker@...aro.org wrote:
> From: Tyler Baker <tyler.baker@...aro.org>
> 
> Set TEST_PROGS only when a build has occurred.
> 
> Signed-off-by: Tyler Baker <tyler.baker@...aro.org>
> ---
>  tools/testing/selftests/breakpoints/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 1822356..54cc3e7 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -12,12 +12,11 @@ endif
>  all:
>  ifeq ($(ARCH),x86)
>  	gcc breakpoint_test.c -o breakpoint_test
> +	TEST_PROGS := breakpoint_test
>  else
>  	echo "Not an x86 target, can't build breakpoints selftests"
>  endif
>  
> -TEST_PROGS := breakpoint_test
> -
>  include ../lib.mk
>  
>  clean:
> 

Hmm. With this change install fails to copy breakpoint_test all
together. Remember setting TEST_PROGS in compile step makes it
not stick around when install target is called. A better approach
would be the following:

if [ -f breakpoint_test ]
    TEST_PROGS := breakpoint_test
fi

include ../lib.mk

-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/