[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <878ucrbhwo.fsf@eliezer.anholt.net>
Date: Thu, 14 May 2015 02:57:43 -0700
From: Eric Anholt <eric@...olt.net>
To: Lee Jones <lee@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org,
linux-rpi-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Stephen Warren <swarren@...dotorg.org>,
devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3 v2] dt/bindings: Add binding for the Raspberry Pi firmware driver
Lee Jones <lee@...nel.org> writes:
> On Wed, 13 May 2015, Eric Anholt wrote:
>
>> This driver will provide support for calls into the firmware that will
>> be used by other drivers like cpufreq and vc4.
>>
>> Signed-off-by: Eric Anholt <eric@...olt.net>
>> ---
>>
>> v2: Improve commit message, point to mailbox.txt for how mboxes work.
>>
>> .../devicetree/bindings/arm/bcm/raspberrypi,firmware.txt | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
>> new file mode 100644
>> index 0000000..33b0043
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,firmware.txt
>> @@ -0,0 +1,16 @@
>> +Raspberry Pi VideoCore firmware driver
>> +
>> +Required properties:
>> +
>> +- compatible: Should be "rasbperrypi,firmware"
>> +- mboxes: Single-entry list which specifies which mailbox
>> + controller and channel is used. See
>> + Documentation/devicetree/bindings/mailbox/mailbox.txt
>> + for the semantics of this property
>
> That's not what it looks like to me. There is no mention of channels
> in a 0 cell property. Keep it simple. How about:
>
> Phandle to the firmware device's Mailbox.
> (See: ../mailbox/mailbox.txt for more information)
Sounds good to me.
Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)
Powered by blists - more mailing lists