Message-ID: <CAOesGMg6vETz1dCgHE1WYUJZ3XdHjdku9YCauYPS-a-avk89HQ@mail.gmail.com>
Date:	Thu, 14 May 2015 09:45:12 -0700
From:	Olof Johansson <olof@...om.net>
To:	Kevin Hilman <khilman@...nel.org>
Cc:	Tobias Jakobi <liquid.acid@....net>,
	Javier Martinez Canillas <javier@...hile0.org>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] MAINTAINERS: ARM: EXYNOS: Add Krzysztof Kozlowski asco-maintainer

On Thu, May 14, 2015 at 8:52 AM, Kevin Hilman <khilman@...nel.org> wrote:
> Tobias Jakobi <liquid.acid@....net> writes:
>
>> Javier Martinez Canillas wrote:
>>> Hello Kukjin,
>>>
>>> On Thu, May 14, 2015 at 3:00 PM, Kukjin Kim <kgene@...nel.org> wrote:
>>>> On 05/14/15 21:15, Krzysztof Kozlowski wrote:
>>>>> Add Krzysztof Kozlowski as a co-maintainer of Samsung Exynos ARM
>>>>> architecture to review the patches. Patches will go as usual - picked up
>>>>> by Kukjin Kim.
>>>>>
>>>> Hi Krzysztof,
>>>>
>>>> Sorry, I don't agree with this patch because you can review any exynos
>>>> patches without maintainer title. And I can focus on the maintainer'r
>>>> role more than now because of change of role ;-) Of course your review
>>>> would be helpful to me.
>>>>
>>>
>>> Sorry but I disagree. Krzysztof has been very active reviewing Exynos
>>> patches and even picking/queuing important fixes while it seems you
>>> were too busy and couldn't pay close attention.
>> I would even go further than that. We're in this situation because the
>> current maintainer didn't do his job properly.
>>
>> I want to point out what gregkh once said about this matter:
>> https://youtu.be/iiED1K98lnw?t=1745
>>
>>
>>
>>> It's really great that due a role change you will have more time to
>>> focus on the maintainership but I don't see why having more
>>> maintainers could be something negative. As long as you work in a
>>> coordinate manner, the more maintainers we have the better IMHO. It
>>> may be that in the future you change your role at your company again
>>> and then it will be good to have something else to take care of the
>>> posted patches ;-)
>> I very much agree with Javier here. Krzysztof promptly responds to
>> patches and usually provides detailed feedback when things need changes.
>> It would be stupid not to accept him as an additional maintainer.
>
> I'll take this as an Acked-by then.
>
> FWIW, I agree with Tobias and Javier, extra help for exynos has been
> sorely needed for a long time, and I am very happy to see someone
> stepping up to help.  Thank you Krzysztof!  (and I apologize in advance
> for the many times I'm likely to misspell your name ;)
>
> I'll be applying this to the arm-soc tree,

I agree, I think it's a great improvement to get another official
maintainer of Samsung's platforms that can share the load and send us
code.

While I often also use the argument that anyone can help review code
without being named a maintainer, in the particular case of Exynos
platforms there's a dire need for more close attention: They're
frequently broken for long periods of time and there's been high
latency for fixes, which has made bisecting hard or impossible for new
failures. Naming Krzysztof as co-maintainer makes it more clear that
we're happy to merge code from him directly as appropriate for latency
reasons and so on.

So:

Acked-by: Olof Johansson <olof@...om.net>


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists