linux-kernel - Re: [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1778706.Xlqg2QcRzz@vostro.rjw.lan>
Date:	Fri, 15 May 2015 02:20:36 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Sudeep Holla <sudeep.holla@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 1/2] cpufreq: arm_big_little: check if the frequency is set correctly

On Monday, April 27, 2015 03:56:18 PM Viresh Kumar wrote:
> On 27 April 2015 at 15:21, Sudeep Holla <sudeep.holla@....com> wrote:
> > The actual frequency is set through "clk_change_rate" which is void
> > function. If the underlying hardware fails and returns error, the error
> > is lost in the clk layer. In order to track such failures, we need to
> > read back the frequency(just the cached value as clk_recalc called after
> > clk->ops->set_rate gets the frequency)
> >
> > This patch adds check to see if the frequency is set correctly or if
> > they were any hardware failures and sends the appropriate errors to the
> > cpufreq core.
> >
> > Cc: Viresh Kumar <viresh.kumar@...aro.org>
> > Reviewed-by: Michael Turquette <mike.turquette@...aro.org>
> > Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> > ---
> >  drivers/cpufreq/arm_big_little.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
> > index e1a6ba66a7f5..f65e19f340d0 100644
> > --- a/drivers/cpufreq/arm_big_little.c
> > +++ b/drivers/cpufreq/arm_big_little.c
> > @@ -186,6 +186,15 @@ bL_cpufreq_set_rate(u32 cpu, u32 old_cluster, u32 new_cluster, u32 rate)
> >                 mutex_unlock(&cluster_lock[old_cluster]);
> >         }
> >
> > +       /*
> > +        * FIXME: clk_set_rate has to handle the case where clk_change_rate
> > +        * can fail due to hardware or firmware issues. Until the clk core
> > +        * layer is fixed, we can check here. In most of the cases we will
> > +        * be reading only the cached value anyway. This needs to  be removed
> > +        * once clk core is fixed.
> > +        */
> > +       if (bL_cpufreq_get_rate(cpu) != new_rate)
> > +               return -EIO;
> >         return 0;
> >  }
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Both queued up for 4.2, thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/