linux-kernel - Re: [PATCH 2/3] scripts/gdb: Fix PEP8 compliance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 May 2015 13:32:10 +0200
From:	Jan Kiszka <jan.kiszka@...mens.com>
To:	Thiébaud Weksteen <thiebaud@...steen.fr>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] scripts/gdb: Fix PEP8 compliance

On 2015-05-14 07:22, Thiébaud Weksteen wrote:
> Signed-off-by: Thiébaud Weksteen <thiebaud@...steen.fr>
> ---
>  scripts/gdb/linux/dmesg.py   | 1 -
>  scripts/gdb/linux/symbols.py | 9 ++++-----
>  scripts/gdb/linux/tasks.py   | 2 ++
>  scripts/gdb/linux/utils.py   | 2 +-
>  4 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/scripts/gdb/linux/dmesg.py b/scripts/gdb/linux/dmesg.py
> index 3c947f0..927d0d2 100644
> --- a/scripts/gdb/linux/dmesg.py
> +++ b/scripts/gdb/linux/dmesg.py
> @@ -12,7 +12,6 @@
>  #
>  
>  import gdb
> -import string
>  
>  from linux import utils
>  
> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
> index cd5bea9..627750c 100644
> --- a/scripts/gdb/linux/symbols.py
> +++ b/scripts/gdb/linux/symbols.py
> @@ -14,9 +14,8 @@
>  import gdb
>  import os
>  import re
> -import string
>  
> -from linux import modules, utils
> +from linux import modules
>  
>  
>  if hasattr(gdb, 'Breakpoint'):
> @@ -97,7 +96,7 @@ lx-symbols command."""
>              return ""
>          attrs = sect_attrs['attrs']
>          section_name_to_address = {
> -            attrs[n]['name'].string() : attrs[n]['address']
> +            attrs[n]['name'].string(): attrs[n]['address']
>              for n in range(int(sect_attrs['nsections']))}
>          args = []
>          for section_name in [".data", ".data..read_mostly", ".rodata", ".bss"]:
> @@ -124,7 +123,7 @@ lx-symbols command."""
>                  addr=module_addr,
>                  sections=self._section_arguments(module))
>              gdb.execute(cmdline, to_string=True)
> -            if not module_name in self.loaded_modules:
> +            if module_name not in self.loaded_modules:
>                  self.loaded_modules.append(module_name)
>          else:
>              gdb.write("no module object found for '{0}'\n".format(module_name))
> @@ -164,7 +163,7 @@ lx-symbols command."""
>          self.load_all_symbols()
>  
>          if hasattr(gdb, 'Breakpoint'):
> -            if not self.breakpoint is None:
> +            if self.breakpoint is not None:
>                  self.breakpoint.delete()
>                  self.breakpoint = None
>              self.breakpoint = LoadModuleBreakpoint(
> diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py
> index e2037d9..89d38e1 100644
> --- a/scripts/gdb/linux/tasks.py
> +++ b/scripts/gdb/linux/tasks.py
> @@ -18,6 +18,7 @@ from linux import utils
>  
>  task_type = utils.CachedType("struct task_struct")
>  
> +
>  def task_lists():
>      global task_type
>      task_ptr_type = task_type.get_type().pointer()
> @@ -38,6 +39,7 @@ def task_lists():
>          if t == init_task:
>              return
>  
> +
>  def get_task_by_pid(pid):
>      for task in task_lists():
>          if int(task['pid']) == pid:
> diff --git a/scripts/gdb/linux/utils.py b/scripts/gdb/linux/utils.py
> index d7ff3a3..0893b32 100644
> --- a/scripts/gdb/linux/utils.py
> +++ b/scripts/gdb/linux/utils.py
> @@ -151,6 +151,6 @@ def get_gdbserver_type():
>              gdbserver_type = GDBSERVER_QEMU
>          elif probe_kgdb():
>              gdbserver_type = GDBSERVER_KGDB
> -        if not gdbserver_type is None and hasattr(gdb, 'events'):
> +        if gdbserver_type is not None and hasattr(gdb, 'events'):
>              gdb.events.exited.connect(exit_handler)
>      return gdbserver_type
> 

Thanks, queued these first 2.

Which tool did you use for identifying the unused imports?

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/