linux-kernel - Re: [PATCH 3/3] scripts/gdb: Remove useless global instruction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5555D94E.5050401@siemens.com>
Date:	Fri, 15 May 2015 13:32:30 +0200
From:	Jan Kiszka <jan.kiszka@...mens.com>
To:	Thiébaud Weksteen <thiebaud@...steen.fr>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] scripts/gdb: Remove useless global instruction

On 2015-05-14 07:22, Thiébaud Weksteen wrote:
> Signed-off-by: Thiébaud Weksteen <thiebaud@...steen.fr>
> ---
>  scripts/gdb/linux/tasks.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py
> index 89d38e1..0fa33b0 100644
> --- a/scripts/gdb/linux/tasks.py
> +++ b/scripts/gdb/linux/tasks.py
> @@ -20,7 +20,6 @@ task_type = utils.CachedType("struct task_struct")
>  
>  
>  def task_lists():
> -    global task_type
>      task_ptr_type = task_type.get_type().pointer()
>      init_task = gdb.parse_and_eval("init_task").address
>      t = g = init_task
> @@ -73,7 +72,6 @@ ia64_task_size = None
>  
>  
>  def get_thread_info(task):
> -    global thread_info_type
>      thread_info_ptr_type = thread_info_type.get_type().pointer()
>      if utils.is_target_arch("ia64"):
>          global ia64_task_size

These are from my early Python days...

Did you check all the other global statements as well? I bet there are
more, e.g. the one in the last line above.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/