linux-kernel - Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150516.171444.245757401088795324.davem@davemloft.net>
Date:	Sat, 16 May 2015 17:14:44 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhelgaas@...gle.com
Cc:	aleksey.makarov@...iga.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, david.daney@...ium.com,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id

From: Bjorn Helgaas <bhelgaas@...gle.com>
Date: Sat, 16 May 2015 09:49:40 -0500

> Hi Aleksey,
> 
> On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov
> <aleksey.makarov@...iga.com> wrote:
>> Signed-off-by: Aleksey Makarov <aleksey.makarov@...iga.com>
>> ---
>>  include/linux/pci_ids.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index e63c02a..3633cc6 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2327,6 +2327,8 @@
>>  #define PCI_DEVICE_ID_ALTIMA_AC9100    0x03ea
>>  #define PCI_DEVICE_ID_ALTIMA_AC1003    0x03eb
>>
>> +#define PCI_VENDOR_ID_CAVIUM           0x177d
> 
> Please read the note at the top of include/linux/pci_ids.h.  If this
> definition is used in two or more drivers, mention that in the
> changelog.  Otherwise, just use the bare hex value or a private
> #define in your driver.

It is referenced from two foo.c files in the same driver.

I don't know what policy we want for situations like that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/