linux-kernel - Re: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 May 2015 10:46:37 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Aleksey Makarov <aleksey.makarov@...iga.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Daney <david.daney@...ium.com>,
	Sunil Goutham <sgoutham@...ium.com>,
	Maciej Czekaj <mjc@...ihalf.com>,
	Ganapatrao Kulkarni <ganapatrao.kulkarni@...iumnetworks.com>,
	Tomasz Nowicki <tomasz.nowicki@...aro.org>,
	Robert Richter <rrichter@...ium.com>,
	Kamil Rytarowski <kamil@...ihalf.com>,
	Thanneeru Srinivasulu <tsrinivasulu@...iumnetworks.com>,
	Sruthi Vangala <svangala@...ium.com>,
	Robert Richter <rric@...nel.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX
 network controller

Just a nit: a license mismatch.

On Fri, 2015-05-15 at 20:36 -0700, Aleksey Makarov wrote:
> --- /dev/null
> +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c

> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.

This states the license is GPL v2 or later. (The other files used for
this module contain an identical comment.)

> +MODULE_LICENSE("GPL v2");

And, according to include/linux/module.h, this states the license is
just GPL v2. So I think that either the license used in the comment at
the top of those files or the ident used in the MODULE_LICENSE() macro
needs to change.

Ditto for the thunder_bgx.ko and the nicvf.ko module.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/