linux-kernel - Re: [PATCH v2] radeon: Deinline indirect register accessor functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 May 2015 00:50:09 +0200
From:	Denys Vlasenko <vda.linux@...glemail.com>
To:	Christian König <christian.koenig@....com>
Cc:	Denys Vlasenko <dvlasenk@...hat.com>,
	Alex Deucher <alexander.deucher@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] radeon: Deinline indirect register accessor functions

On Mon, May 18, 2015 at 9:09 PM, Christian König
<christian.koenig@....com> wrote:
>> r600_uvd_ctx_rreg: 111 bytes, 4 callsites
>> r600_uvd_ctx_wreg: 113 bytes, 5 callsites
>> eg_pif_phy0_rreg: 106 bytes, 13 callsites
>> eg_pif_phy0_wreg: 108 bytes, 13 callsites
>> eg_pif_phy1_rreg: 107 bytes, 13 callsites
>> eg_pif_phy1_wreg: 108 bytes, 13 callsites
>> rv370_pcie_rreg: 111 bytes, 21 callsites
>> rv370_pcie_wreg: 113 bytes, 24 callsites
>> r600_rcu_rreg: 111 bytes, 16 callsites
>> r600_rcu_wreg: 113 bytes, 25 callsites
>> cik_didt_rreg: 106 bytes, 10 callsites
>> cik_didt_wreg: 107 bytes, 10 callsites
>> tn_smc_rreg: 106 bytes, 126 callsites
>> tn_smc_wreg: 107 bytes, 116 callsites
>> eg_cg_rreg: 107 bytes, 20 callsites
>> eg_cg_wreg: 108 bytes, 52 callsites

> Sorry haven't noticed that before:
>
> radeon_device.c is most likely not the right place for the non-inlined
> functions. Please move them into to the appropriate files for each
> generation.

Will do (probably tomorrow, not today).

Can you help me here a bit?
There are LOTS of  *.c files in drm/radeon/.
I guess r600_ functions should go into r600.c,
rv370_ to rv730_dpm.c (right?),
but some of the function names are less clear (to me).

Where would you like eg_pif_phyN_r/wreg() go? evergreen.c?
Should eg_cg_r/wreg() also go to this file?

cik_didt_r/wreg() - to cik.c?

tn_smc_r/wreg()? Is tn = trinity? so, trinity_smc.c?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/