linux-kernel - Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150518164242.GB12138@sudip-PC>
Date:	Mon, 18 May 2015 22:12:42 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	"DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@...teon.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"lambert.quentin@...il.com" <lambert.quentin@...il.com>,
	"mdcasey@...bloom.com" <mdcasey@...bloom.com>,
	"julia.lawall@...6.fr" <julia.lawall@...6.fr>,
	"kolbeinnkarls@...il.com" <kolbeinnkarls@...il.com>,
	"himangi774@...il.com" <himangi774@...il.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Babu, Viswanathan (V.)" <vbabu3@...teon.com>
Subject: Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather
 assignment

On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
> On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> > On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > > setup_timer is used for timer parameter setup rather than direct
> > > assignment
> > > 
> > > Signed-off-by: Gnanachandran Dhanapal <gdhanapa@...teon.com>
> > 
> > your From: name and Signed-off-by: names are not matching. They should
> > be same.
> 
> If there's a specific "From: " in the _body_ of the email,
> that's true, but the sender email "From: " header and the
> Signed-off-by: line do not have to match.
But Greg usually rejects these patches where the sender "From:" header
and Signed-off-by: doesnot match. Just for example:

https://lkml.org/lkml/2014/11/25/924

regards
sudip

> 
> A "From: " line in the email body should only be used when
> the patch is from a different sender than the sign-off.
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/