linux-kernel - Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1505181948310.2065@localhost6.localdomain6>
Date:	Mon, 18 May 2015 19:49:30 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	"DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@...teon.com>
cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"lambert.quentin@...il.com" <lambert.quentin@...il.com>,
	"mdcasey@...bloom.com" <mdcasey@...bloom.com>,
	"julia.lawall@...6.fr" <julia.lawall@...6.fr>,
	"kolbeinnkarls@...il.com" <kolbeinnkarls@...il.com>,
	"himangi774@...il.com" <himangi774@...il.com>,
	"joe@...ches.com" <joe@...ches.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Babu, Viswanathan (V.)" <vbabu3@...teon.com>
Subject: Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather
 assignment

>  void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data)
>  {
> -	ptimer->function = fun;
> -	ptimer->data = data;
>  	init_timer(ptimer);
> +	setup_timer(ptimer, fun, data);
>  }

setup_timer also subsumes init_timer.  Check the definition.  Probably you 
can delete this function completely.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/