linux-kernel - Re: [PATCH 2/7 V2] workqueue: simplify wq_update_unbound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 May 2015 16:21:12 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7 V2] workqueue: simplify wq_update_unbound_numa()

On Tue, May 12, 2015 at 08:32:30PM +0800, Lai Jiangshan wrote:
> wq_update_unbound_numa() is known be called with wq_pool_mutex held.
> 
> But wq_update_unbound_numa() requests wq->mutex before reading
> wq->unbound_attrs, wq->numa_pwq_tbl[] and wq->dfl_pwq.  But these fields
> were changed to be allowed being read with wq_pool_mutex held.  So we
> simply remove the mutex_lock(&wq->mutex).
> 
> Without the dependence on the the mutex_lock(&wq->mutex), the test
> of wq->unbound_attrs->no_numa can also be moved upward.
> 
> The old code need a long comment to describe the stableness of
> @wq->unbound_attrs which is also guaranteed by wq_pool_mutex now,
> so we don't need this such comment.
> 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>

Applied 1-2 to wq/for-4.2.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/