linux-kernel - Re: [GIT PULL] ring-buffer: Replace this_cpu_*() with __this_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 May 2015 16:40:33 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	stable <stable@...r.kernel.org>,
	Christoph Lameter <cl@...ux.com>,
	Uwe Kleine-Koenig <u.kleine-koenig@...gutronix.de>
Subject: Re: [GIT PULL] ring-buffer: Replace this_cpu_*() with
 __this_cpu_*()

On Mon, 18 May 2015 12:50:43 -0700
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Thu, Mar 19, 2015 at 3:16 PM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> >
> > So I don't think the ring-buffer change is necessarily _wrong_, but if
> > this is a performance issue, why don't we just fix it up for the
> > generic case rather than for just one user?
> 
> This this_cpu_generic_read/this_cpu_generic_write() performance thing
> seems to have dropped off everybody's radar.
> 
> Do people still care? Is it an issue?

Note, the ring buffer issues exasperated the problem because the
preempt_disable() itself was being traced (function tracer) and this
was for the code that was to detect recursion. Luckily, the function
tracer had its own recursion detection to prevent an infinite recursion
from happening and crashing the kernel, but the double call was
definitely being noticed.

Now, as for preempt_disable() being called for a simple per cpu read,
that is probably overkill. But I think Christoph is the one to answer
this.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/