linux-kernel - Re: [PATCH 3/3] vTPM: support little endian guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 May 2015 16:18:44 -0500 (CDT)
From:	Ashley Lai <ashley@...leylai.com>
To:	Ashley Lai <ashley@...leylai.com>
cc:	"Hon Ching(Vicky) Lo" <honclo@...ux.vnet.ibm.com>,
	tpmdd-devel@...ts.sourceforge.net, Peter Huewe <PeterHuewe@....de>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	Vicky Lo <honclo2014@...il.com>, linux-kernel@...r.kernel.org,
	Joy Latten <jmlatten@...ux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] vTPM: support little endian guests


>> @@ -208,11 +229,43 @@ static int tpm_binary_bios_measurements_show(struct 
>> seq_file *m, void *v)
>> 	struct tcpa_event *event = v;
>> 	char *data = v;
>> 	int i;
>> -
>> -	for (i = 0; i < sizeof(struct tcpa_event) + event->event_size; i++)
>> +	u32 x;
>> +	char tmp[4];
>> +
>> +	/* PCR */
>> +	x = convert_to_host_format(event->pcr_index);
>> +	memcpy(tmp, &x, 4);
>> +	for (i = 0; i < 4; i++)
>> +		seq_putc(m, tmp[i]);
>> +	data += 4;
>> +
>> +	/* Event Type */
>> +	x = convert_to_host_format(event->event_type);
>> +	memcpy(tmp, &x, 4);
>> +	for (i = 0; i < 4; i++)
>> +		seq_putc(m, tmp[i]);
>> +	data += 4;
>> +
>> +	/* HASH */
>> +	for (i = 0; i < 20; i++)
>> 		seq_putc(m, data[i]);
>> +	data += 20;
>> +
>> +	/* Size */
>> +	x = convert_to_host_format(event->event_size);
>> +	memcpy(tmp, &x, 4);
>> +	for (i = 0; i < 4; i++)
>> +		seq_putc(m, tmp[i]);
>> +	data += 4;
>> +
>> +	/* Data */
>> +	if (convert_to_host_format(event->event_size)) {
>> +		for (i = 0; i < convert_to_host_format(event->event_size); 
>> i++)
>> +			seq_putc(m, data[i]);
>> +	}
>>
>> 	return 0;
>> +
>> }
> If the tcpa_event structure is converted, you may be able to get away with 
> memcpy and the for loop.

You can get away with memcpy and use the original for loop.
   for (i = 0; i < sizeof(struct tcpa_event) + event->event_size; i++)
     seq_putc(m, data[i]);

Thanks,
--Ashley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/