linux-kernel - Re: [PATCH] x86, cpuinfo x86_model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 May 2015 18:17:22 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	Andy Lutomirski <luto@...capital.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	Brian Gerst <brgerst@...il.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Igor Mammedov <imammedo@...hat.com>,
	the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup



On 05/19/2015 04:31 PM, Borislav Petkov wrote:
> On Tue, May 19, 2015 at 01:16:23PM -0700, Andy Lutomirski wrote:
>> It's not just chunk size; it's the direction.  If the dest starts
>> after the source but overlaps it and you copy forwards, then you can
>> clobber the end of the source before you read it.  memmove is
> 
> Some things should simply be done solely in userspace :-)
> 
>> specifically intended to avoid this.
>>
>> Would it be possible to just use memmove directly?
> 
> Yeah.
> 
> Prarit, care to send a v2?

Yep, I can do that.  It'll have to wait until I get into the office in the
morning so I can retest.

P.

> 
> Thanks.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/