linux-kernel - Re: [PATCH] x86, cpuinfo x86_model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150520063435.GA24430@gmail.com>
Date:	Wed, 20 May 2015 08:34:35 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Andy Lutomirski <luto@...capital.net>,
	Borislav Petkov <bp@...en8.de>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Igor Mammedov <imammedo@...hat.com>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Brian Gerst <brgerst@...il.com>
Subject: Re: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup


* Prarit Bhargava <prarit@...hat.com> wrote:

>  arch/x86/kernel/cpu/common.c |   17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)

So I saw this title:

   [PATCH] x86, cpuinfo x86_model_id whitespace cleanup

... and in an early morning deconcentrated state was skipped the 
changelog and was looking for a whitespace coding style cleanup:

> @@ -431,18 +430,10 @@ static void get_model_name(struct cpuinfo_x86 *c)
>  	c->x86_model_id[48] = 0;
>  
>  	/*
> -	 * Intel chips right-justify this string for some dumb reason;
> -	 * undo that brain damage:
> +	 * Remove leading whitespace on Intel processors and trailing
> +	 * whitespace on AMD processors.
>  	 */
> -	p = q = &c->x86_model_id[0];
> -	while (*p == ' ')
> -		p++;
> -	if (p != q) {
> -		while (*p)
> -			*q++ = *p++;
> -		while (q <= &c->x86_model_id[48])
> -			*q++ = '\0';	/* Zero-pad the rest */
> -	}
> +	strlcpy(c->x86_model_id, strim(c->x86_model_id), 48);
>  }

Which this clearly isnt!

Fortunately before complaining about that I read the changelog as 
well, and realized that the 'whitespace cleanup' is done to 
/proc/cpuinfo ABI output.

Could you please make the title less ambiguous, so that sleepy kernel 
developers get the right idea what the patch looks like, from the 
title alone? Git shortlogs will vastly improve as well.

Something like:

   [PATCH] x86/cpu: Strip leading and trailing spaces from the /proc/cpuinfo CPU model field

... or so would work very well for me!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/