lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 May 2015 18:10:27 +0900 From: Masahiro Yamada <yamada.masahiro@...ionext.com> To: Jiri Slaby <jslaby@...e.cz> Cc: Matthias Brugger <matthias.bgg@...il.com>, Peter Hurley <peter@...leysoftware.com>, Alan Cox <alan@...ux.intel.com>, Tony Lindgren <tony@...mide.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Joachim Eastwood <manabian@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-serial@...r.kernel.org, Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, John Crispin <blogic@...nwrt.org> Subject: Re: [PATCH v3] serial: 8250_uniphier: add UniPhier serial driver 2015-05-19 17:57 GMT+09:00 Jiri Slaby <jslaby@...e.cz>: > On 05/19/2015, 10:54 AM, Masahiro Yamada wrote: >>>> +#define UNIPHIER_UART_CHAR_FCR 3 /* Character / FIFO Control Register */ >>>> +#define UNIPHIER_UART_LCR_MCR 4 /* Line/Modem Control Register */ >>>> +#define UNIPHIER_UART_LCR_SHIFT 8 >>>> +#define UNIPHIER_UART_DLR 9 /* Divisor Latch Register */ >>> >>> Nit pick: Please fix identation. After "define" just put one blank. >>> I personally prefer that the define values are aligned by tabs, but >>> that's up tu you. >>> >> >> I intentionally use deeper indentation for *_SHIFT >> because I want to clearly show UNIPHIER_UART_LCR_SHIFT >> belongs to UNIPHIER_UART_LCR_MCR register. >> >> I also want to describe them within 80 columns including comments, >> so I cannot insert extra TABs to align the values. > > Hi, what about one space between # and define which is used sometimes? With more one space after #, '8' goes to the next stop, so it makes no difference. Is this a problem? It almost seems a bike shed... -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists