linux-kernel - Re: [PATCH v3] serial: 8250_uniphier: add UniPhier serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150519104800.5ebd3518@lxorguk.ukuu.org.uk>
Date:	Tue, 19 May 2015 10:48:00 +0100
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	Matthias Brugger <matthias.bgg@...il.com>,
	Peter Hurley <peter@...leysoftware.com>,
	John Crispin <blogic@...nwrt.org>,
	Tony Lindgren <tony@...mide.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Joachim Eastwood <manabian@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-serial@...r.kernel.org,
	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Jiri Slaby <jslaby@...e.cz>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	"linux-arm-kernel@...ts.infradead.org\" <linux-arm-kernel@...ts.infradead.org>"@lxorguk.ukuu.org.uk
Subject: Re: [PATCH v3] serial: 8250_uniphier: add UniPhier serial driver

> I intentionally use deeper indentation for *_SHIFT
> because I want to clearly show  UNIPHIER_UART_LCR_SHIFT
> belongs to UNIPHIER_UART_LCR_MCR register.

Seems sensible to do it that way to me and a lot of other bits of the
kernel do.

The only other question I have is about the unipher_serial_out. If I am
writing a "special" register then the sequence becomes

- read 32bits
- modify
- write 32bits

That means that it's no longer atomic safe as the kernel expects.
Checking the users FCR seems safe, LCR is probably safe and MCR likewise
so I don't see a problem but I think it's worth noting in case anyone
else does.

Finally can you add a comment in serial_in and serial_out where one
switch case drops through into the next so its obvious to anyone looking
at Coverity and other analyser output that this drop through was
intentional ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/