linux-kernel - Re: [patch 2/6] x86, perf, cqm: Use proper data type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1505191502450.4225@nanos>
Date:	Tue, 19 May 2015 15:03:38 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Matt Fleming <matt@...eblueprint.co.uk>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Vikas Shivappa <vikas.shivappa@...ux.intel.com>,
	x86@...nel.org, Matt Fleming <matt.fleming@...el.com>,
	Will Auld <will.auld@...el.com>,
	Kanaka Juvva <kanaka.d.juvva@...el.com>
Subject: Re: [patch 2/6] x86, perf, cqm: Use proper data type

On Tue, 19 May 2015, Matt Fleming wrote:

> On Tue, 19 May, at 12:00:51AM, Thomas Gleixner wrote:
> > int is really not a proper data type for a MSR. Use u32 to make it
> > clear that we are dealing with a 32bit unsigned hardware value.
> > 
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> > ---
> >  arch/x86/kernel/cpu/perf_event_intel_cqm.c |    4 ++--
> >  include/linux/perf_event.h                 |    2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> Yeah, makes sense, but this is missing a bunch of changes to other
> functions that pass rmids around.

Right. I cared about the stuff which handles the cached state.
 
> Lemme take a swing at that.

Yes, please.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/