linux-kernel - Re: [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with "jedec,spi-nor"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150520213546.GN11598@ld-irv-0074>
Date:	Wed, 20 May 2015 14:35:46 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Mark Rutland <mark.rutland@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Marek Vasut <marex@...x.de>,
	linux-spi <linux-spi@...r.kernel.org>
Subject: Re: [PATCH] Documentation: dt: mtd: replace "nor-jedec" binding with
 "jedec,spi-nor"

On Tue, May 19, 2015 at 09:27:50AM +0200, Rafał Miłecki wrote:
> On 19 May 2015 at 03:34, Brian Norris <computersforpeace@...il.com> wrote:
> > So how about the following patch? It seems like we'll need to be able to
> > ignore useless 'modalias' values in cases like this:
> >
> >         // modalias = "shinynewdevice"
> >         compatible = "myvendor,shinynewdevice", "jedec,spi-nor";
> >
> > and also if somebody leaves off the entire shinynewdevice string:
> >
> >         // modalias = "spi-nor"
> >         compatible = "jedec,spi-nor";
> >
> > So we rework the spi-nor library to not reject "bad" names, and just
> > fall back to autodetection, and we add the .of_match_table to properly
> > catch all "jedec,spi-nor".
> 
> That's nice but what about platforms using platform data instead of
> DT? I would like to use some kind of "spi-nor" (with some prefix
> *maybe*) for them too.

For platform devices, you might as well just use the name of the driver,
which is 'm25p80'. Isn't that how most platform devices are matched with
drivers?

Or if you can propose other clean solutions, I'm all ears. I'm likely to
merge this patch for 4.2 unless a better solution comes up, though.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/