linux-kernel - RE: [PATCH] regmap: add virtual PMIC IPC bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C6287702A945AC47BE5DB5DFD4B5C6DD018B845B@SHSMSX104.ccr.corp.intel.com>
Date:	Wed, 20 May 2015 01:02:49 +0000
From:	"Zha, Qipeng" <qipeng.zha@...el.com>
To:	Mark Brown <broonie@...nel.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Yang, Fei" <fei.yang@...el.com>,
	"Zhong, Huiquan" <huiquan.zhong@...el.com>,
	"Chen, Jason CJ" <jason.cj.chen@...el.com>,
	"Zheng, Qi" <qi.zheng@...el.com>
Subject: RE: [PATCH] regmap: add virtual PMIC IPC bus support

Hi 

Not sure what's your mean using regmap api without bus suport for this case
Confirm many device driver will use this api.

The detail is
Beside pmic core driver itself, there are many pmic function device dirvers, 
such as gpio, theremal, charger, bcu ..., will use this regmap api to access registers.

Using regmap, we can keep transparent for register access in these sub pmic device drivers ,
Since we do also have different pmic hw which is controlled by i2c, not ipc here
If don't add such regmap core support here, we need wrap a similar layer as regmap core for these sub device drivers.

Best wishes
Qipeng

-----Original Message-----
From: Mark Brown [mailto:broonie@...nel.org] 
Sent: Tuesday, May 19, 2015 8:09 PM
To: Zha, Qipeng
Cc: linux-kernel@...r.kernel.org; Yang, Fei; Zhong, Huiquan; Chen, Jason CJ; Zheng, Qi
Subject: Re: [PATCH] regmap: add virtual PMIC IPC bus support

On Tue, May 19, 2015 at 04:57:00AM +0000, Zha, Qipeng wrote:

> >Why is this being added to the regmap core rather than being 
> >implemented in using the reg_write() and reg_read() callbacks in the 
> >core driver for the PMIC?

> Thanks. I don't receive this message before in eamil.
> Current regmap only support register access  using several bus:  i2c, spi, ac97 ...
> But register access for intel pmic are done by hardware ipc, so we add 
> such support in regmap core, To make pmic subdevice drivers can use generic regmap r/w API to access registers.

That doesn't really address my concern - we already have the reg_read() and reg_write() interface so devices can use regmap without a bus in the core.  The question is if this is something that's going to be used by many devices so there's code to share or if it's something that's only going to be used by this PMIC in which case keeping it in the driver should be easier.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/