linux-kernel - Re: [PATCH] regmap: add virtual PMIC IPC bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150519120915.GJ2761@sirena.org.uk>
Date:	Tue, 19 May 2015 13:09:15 +0100
From:	Mark Brown <broonie@...nel.org>
To:	"Zha, Qipeng" <qipeng.zha@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Yang, Fei" <fei.yang@...el.com>,
	"Zhong, Huiquan" <huiquan.zhong@...el.com>,
	"Chen, Jason CJ" <jason.cj.chen@...el.com>,
	"Zheng, Qi" <qi.zheng@...el.com>
Subject: Re: [PATCH] regmap: add virtual PMIC IPC bus support

On Tue, May 19, 2015 at 04:57:00AM +0000, Zha, Qipeng wrote:

> >Why is this being added to the regmap core rather than being implemented
> >in using the reg_write() and reg_read() callbacks in the core driver for
> >the PMIC?

> Thanks. I don't receive this message before in eamil.
> Current regmap only support register access  using several bus:  i2c, spi, ac97 ...
> But register access for intel pmic are done by hardware ipc, so we add such support in regmap core,
> To make pmic subdevice drivers can use generic regmap r/w API to access registers.

That doesn't really address my concern - we already have the reg_read()
and reg_write() interface so devices can use regmap without a bus in the
core.  The question is if this is something that's going to be used by
many devices so there's code to share or if it's something that's only
going to be used by this PMIC in which case keeping it in the driver
should be easier.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)