lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 May 2015 15:26:10 -0700 From: Brian Norris <computersforpeace@...il.com> To: Tejun Heo <tj@...nel.org> Cc: Fabio Estevam <festevam@...il.com>, Kishon Vijay Abraham I <kishon@...com>, Mark Rutland <mark.rutland@....com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Hans de Goede <hdegoede@...hat.com>, Florian Fainelli <f.fainelli@...il.com>, Pawel Moll <pawel.moll@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kevin Cernekee <cernekee@...il.com>, linux-kernel <linux-kernel@...r.kernel.org>, linux-ide@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>, Gregory Fong <gregory.0xf0@...il.com>, Kumar Gala <galak@...eaurora.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips On Thu, May 21, 2015 at 3:20 PM, Tejun Heo <tj@...nel.org> wrote: > On Thu, May 21, 2015 at 07:16:07PM -0300, Fabio Estevam wrote: >> On Tue, May 12, 2015 at 8:28 PM, Brian Norris >> <computersforpeace@...il.com> wrote: >> >> > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci"); >> > + ahci = devm_ioremap_resource(&pdev->dev, res); >> > + if (IS_ERR(ahci)) >> > + return 0; >> >> You should propagate 'return PTR_ERR(ahci)' instead. > > Brian, can you please update the patch? Note how the function brcm_ahci_get_portmask() is used. In brcm_ahci_probe(): priv->port_mask = brcm_ahci_get_portmask(pdev, priv); if (!priv->port_mask) return -ENODEV; I could try to change the return semantics if really needed. Or I could add some comments on brcm_ahci_get_portmask() to note its return semantics. Or I could just leave the driver as-is. Your call. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists