linux-kernel - Re: [PATCH] spmi: add command tracepoints for SPMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ae9ad74d48d03a477ae6ffca028a5d3.squirrel@www.codeaurora.org>
Date:	Thu, 21 May 2015 17:24:09 -0600
From:	"Ankit Gupta" <ankgupta@...eaurora.org>
To:	"Stephen Boyd" <sboyd@...eaurora.org>
Cc:	"Ankit Gupta" <ankgupta@...eaurora.org>, gavidov@...eaurora.org,
	sdharia@...eaurora.org, mlocke@...eaurora.org,
	linux-arm-msm@...r.kernel.org, gregkh@...uxfoundation.org,
	ivan.ivanov@...aro.org, linux-kernel@...r.kernel.org,
	svarbanov@...sol.com, galak@...eaurora.org, agross@...eaurora.org
Subject: Re: [PATCH] spmi: add command tracepoints for SPMI

> On 05/18/15 14:51, Ankit Gupta wrote:
>> Add tracepoints to retrieve information about read, write
>> and non-data commands. For performance measurement support
>> tracepoints are added at the beginning and at the end of
>> transfers. Following is a list showing the new tracepoint
>> events. The "cmd" parameter here represents the opcode, SID,
>> and full 16-bit address.
>>
>> spmi_write_begin: cmd and data buffer.
>> spmi_write_end  : cmd and return value.
>> spmi_read_begin : cmd.
>> spmi_read_end   : cmd, return value and data buffer.
>> spmi_cmd        : cmd.
>>
>> The reason that cmd appears at both the beginning and at
>> the end event is that SPMI drivers can request commands
>> concurrently. cmd helps in matching the corresponding
>> events.
>>
>> SPMI tracepoints can be enabled like:
>>
>> echo 1 >/sys/kernel/debug/tracing/events/spmi/enable
>>
>> and will dump messages that can be viewed in
>> /sys/kernel/debug/tracing/trace that look like:
>>
>> ... spmi_read_begin: opc=56 sid=00 addr=0x0000
>> ... spmi_read_end: opc=56 sid=00 addr=0x0000 ret=0 len=02 buf=0x[01-40]
>> ... spmi_write_begin: opc=48 sid=00 addr=0x0000 len=3 buf=0x[ff-ff-ff]
>>
>> Signed-off-by: Ankit Gupta <ankgupta@...eaurora.org>
>> Signed-off-by: Gilad Avidov <gavidov@...eaurora.org>
>> Suggested-by: Sagar Dharia <sdharia@...eaurora.org>
>> ---
>
> Assuming you fix sign-off-chain:
>
> Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

Sorry, Missed your this email, will upload a new patch with just change of
sign-off order.

Thanks
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/